Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper error handling #13

Open
h7x4 opened this issue Jan 19, 2022 · 0 comments
Open

Add proper error handling #13

h7x4 opened this issue Jan 19, 2022 · 0 comments
Labels
Feature Request Improvements and features for the application Medium Medium-sized tasks Technical Debt Stuff that somewhat works, but needs refactoring/rewriting
Milestone
Beta release

Comments

@h7x4
Copy link
Owner

h7x4 commented Jan 19, 2022

The app needs to handle errors properly. More specifically, it needs to recognize when there is no internet connection, 404 not founds and generic errors when it's unclear what happened. Following are relevant files:

https://github.com/h7x4ABk3g/Jisho-Study-Tool/blob/17d6f862a280fecc8db71dff5bd7c0d0814fa50f/lib/services/handwriting.dart#L91-L98

https://github.com/h7x4ABk3g/Jisho-Study-Tool/blob/17d6f862a280fecc8db71dff5bd7c0d0814fa50f/lib/routing/router.dart#L39-L50

https://github.com/h7x4ABk3g/Jisho-Study-Tool/blob/17d6f862a280fecc8db71dff5bd7c0d0814fa50f/lib/components/kanji/kanji_result_body.dart#L17-L25

  • /lib/components/common/internet_error.dart
  • /lib/components/common/unknown_error.dart
@h7x4 h7x4 added Feature Request Improvements and features for the application TODO Technical Debt Stuff that somewhat works, but needs refactoring/rewriting labels Jan 19, 2022
@h7x4 h7x4 added this to the Beta release milestone Jan 19, 2022
@h7x4 h7x4 added Medium Medium-sized tasks and removed TODO labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Improvements and features for the application Medium Medium-sized tasks Technical Debt Stuff that somewhat works, but needs refactoring/rewriting
Projects
None yet
Milestone
Beta release
Development

No branches or pull requests
1 participant
@h7x4