Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: arrow parsing for nested and nullable fields #519

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: arrow parsing for nested and nullable fields #519

wants to merge 3 commits into from

Conversation

alvarowolfx
Copy link
Contributor

Improves parsing of arrow records to TableRow format by increasing test coverage and checking arrow data types.

Fixes #518 🦕

@alvarowolfx alvarowolfx requested review from a team as code owners October 15, 2024 19:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. labels Oct 15, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 15, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 15, 2024
@alvarowolfx alvarowolfx added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 15, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2024
leahecole
leahecole requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly questions! Probably just needs a few comments for other maintainers who might not be as familiar with arrow

src/reader/arrow_transform.ts Show resolved Hide resolved
src/reader/arrow_transform.ts Outdated Show resolved Hide resolved
system-test/reader_client_test.ts Outdated Show resolved Hide resolved
@leahecole leahecole self-assigned this Oct 17, 2024
leahecole
leahecole approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two suggestions but otherwise lgtm

src/reader/arrow_transform.ts Show resolved Hide resolved
system-test/reader_client_test.ts Show resolved Hide resolved
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@mrfaizal mrfaizal Awaiting requested review from mrfaizal mrfaizal is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@leahecole leahecole

Labels
api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. owlbot:run Add this label to trigger the Owlbot post processor. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadClient throws on null values
3 participants
@alvarowolfx @leahecole @yoshi-kokoro