Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gensupport/storage: allow Accept-Encoding header #2757

Open
BrennaEpp opened this issue Aug 27, 2024 · 0 comments · May be fixed by #2758
Open

gensupport/storage: allow Accept-Encoding header #2757

BrennaEpp opened this issue Aug 27, 2024 · 0 comments · May be fixed by #2758
Assignees
@BrennaEpp
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@BrennaEpp
Copy link
Contributor

BrennaEpp commented Aug 27, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
In Storage, we use the Accept-Encoding header to allow users to download the zipped version of their data, see ReadCompressed. We cannot support this in JSON because the header is disallowed.

Describe the solution you'd like
Allow the header, at least for storage media downloads. This requires changes to the generated code.

Describe alternatives you've considered
Allow the header in general. This can be done in gensupport. (edit: this actually would be my preferred solution, but it may impact other libraries - linked PR is for the first option)
@BrennaEpp BrennaEpp added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Aug 27, 2024
@BrennaEpp BrennaEpp linked a pull request Aug 27, 2024 that will close this issue
Open
@BrennaEpp BrennaEpp added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Aug 28, 2024
@codyoss codyoss assigned quartzmo and unassigned codyoss Aug 29, 2024
@quartzmo quartzmo assigned BrennaEpp and unassigned quartzmo Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrennaEpp BrennaEpp

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(storage): allow Accept-Encoding header BrennaEpp/google-api-go-client
3 participants
@quartzmo @codyoss @BrennaEpp