From 95ac257f094f02b63b9b837270010d619011a0e3 Mon Sep 17 00:00:00 2001
From: Sergey Stepanov <sergystepanov@gmail.com>
Date: Mon, 4 Mar 2024 18:57:40 +0300
Subject: [PATCH] Calculate <video> size not in fullscreen

---
 web/js/stream/stream.js | 58 +++++++++++++++++++++++++----------------
 1 file changed, 35 insertions(+), 23 deletions(-)

diff --git a/web/js/stream/stream.js b/web/js/stream/stream.js
index af2dc0bec..76b9cfcfe 100644
--- a/web/js/stream/stream.js
+++ b/web/js/stream/stream.js
@@ -15,6 +15,7 @@ const stream = (() => {
             },
             state = {
                 screen: screen,
+                fullscreen: false,
                 timerId: null,
                 w: 0,
                 h: 0,
@@ -27,11 +28,7 @@ const stream = (() => {
             screen.play()
                 .then(() => log.info('Media can autoplay'))
                 .catch(error => {
-                    // Usually error happens when we autoplay unmuted video, browser requires manual play.
-                    // We already muted video and use separate audio encoding so it's fine now
-                    log.error('Media Failed to autoplay');
-                    log.error(error)
-                    // TODO: Consider workaround
+                    log.error('Media failed to play', error);
                 });
         }
 
@@ -49,6 +46,23 @@ const stream = (() => {
 
         const getVideoEl = () => screen
 
+        const getActualVideoSize = () => {
+            if (state.fullscreen) {
+                // we can't get real <video> size without black bars, so we're trying to
+                // derive its dimensions from the known width or height
+                // and by calculating unknown dimension from the aspect ratio
+                const horizontal = screen.videoWidth > screen.videoHeight;
+                return {
+                    w: horizontal ? screen.offsetHeight * state.aspect : screen.offsetWidth,
+                    h: horizontal ? screen.offsetHeight : screen.offsetWidth * state.aspect
+                }
+            }
+
+            const size = screen.getBoundingClientRect()
+
+            return {w: size.width, h: size.height}
+        }
+
         screen.onerror = (e) => {
             // video playback failed - show a message saying why
             switch (e.target.error.code) {
@@ -155,16 +169,16 @@ const stream = (() => {
         let pointerLocked = false;
 
         event.sub(FULLSCREEN_CHANGE, async (fullscreenEl) => {
+            state.fullscreen = !!fullscreenEl;
+
             const w = window.screen.width ?? window.innerWidth;
             const h = window.screen.height ?? window.innerHeight;
 
             const ww = document.documentElement.innerWidth;
             const hh = document.documentElement.innerHeight;
 
-            const fullscreen = !!fullscreenEl;
-
             screen.style.padding = '0'
-            if (fullscreen) {
+            if (state.fullscreen) {
                 const dw = (w - ww * state.aspect) / 2
                 screen.style.padding = `0 ${dw}px`
                 // chrome bug
@@ -173,31 +187,29 @@ const stream = (() => {
                     screen.style.padding = `0 ${dw}px`
                 }, 1)
             }
-            makeFullscreen(fullscreen);
+            makeFullscreen(state.fullscreen);
 
             screen.blur();
 
-            if (fullscreen && !pointerLocked) {
+            if (state.fullscreen && !pointerLocked) {
                 // event.pub(POINTER_LOCK_CHANGE, screen);
                 await screen.requestPointerLock(
-                    // { unadjustedMovement: true,}
+                // { unadjustedMovement: true,}
                 );
             }
 
-            screen.onpointerdown = fullscreen ? handlePointerDown : null;
-            screen.onpointerup = fullscreen ? handlePointerUp : null;
+            screen.onpointerdown = state.fullscreen ? handlePointerDown : null;
+            screen.onpointerup = state.fullscreen ? handlePointerUp : null;
 
             // !to flipped
         })
 
         let ex = 0, ey = 0;
         const scaleCursorPos = (x, y) => {
-            const horizontal = screen.videoWidth > screen.videoHeight;
+            const {w, h} = getActualVideoSize();
 
-            const arW = horizontal ? screen.offsetHeight * state.aspect : screen.offsetHeight;
-            const arH = horizontal ? screen.offsetHeight : screen.offsetWidth * state.aspect;
-            const sw = arW / screen.videoWidth;
-            const sh = arH / screen.videoHeight;
+            const sw = w / screen.videoWidth;
+            const sh = h / screen.videoHeight;
 
             const rez = {
                 dx: x / sw + ex,
@@ -214,8 +226,8 @@ const stream = (() => {
         }
 
         const handlePointerMove = (e) => {
-            const delta = scaleCursorPos(e.movementX, e.movementY);
-            event.pub(MOUSE_MOVED, delta);
+            // !to fix ff https://github.com/w3c/pointerlock/issues/42
+            event.pub(MOUSE_MOVED, scaleCursorPos(e.movementX, e.movementY));
         }
 
         event.sub(POINTER_LOCK_CHANGE, (lockedEl) => {
@@ -240,9 +252,9 @@ const stream = (() => {
             state.screen.style['object-fit'] = a.toFixed(6) !== a2.toFixed(6) ? 'fill' : fit
             state.h = hh
             state.w = Math.floor(hh * a)
-            state.screen.setAttribute('width', ww)
-            state.screen.setAttribute('height', hh)
-            state.screen.style.aspectRatio = state.aspect
+            state.screen.setAttribute('width', '' + ww)
+            state.screen.setAttribute('height', '' + hh)
+            state.screen.style.aspectRatio = '' + state.aspect
         })
 
         return {