Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report as app context what's the current screen during the error #3140

Closed
Tracked by #18
kahest opened this issue Jul 12, 2023 · 1 comment · Fixed by #3346
Closed
Tracked by #18

Report as app context what's the current screen during the error #3140

kahest opened this issue Jul 12, 2023 · 1 comment · Fixed by #3346
Assignees
@brustolin
Labels
Platform: Cocoa Type: Enhancement

Comments

@kahest
Copy link
Member

kahest commented Jul 12, 2023 •
edited
Loading

see getsentry/team-sdks#18
@marandaneto marandaneto mentioned this issue Jul 18, 2023
Closed
2 tasks
@kahest kahest transferred this issue from getsentry/team-mobile Jul 12, 2023
@kahest kahest changed the title Cocoa Report as app context what's the current activity during the error Jul 12, 2023
@philipphofmann philipphofmann changed the title Report as app context what's the current activity during the error Report as app context what's the current screen during the error Jul 12, 2023
@brustolin
Copy link
Contributor

  • For UIKit, we can navigate the view controller hierarchy to found out to top most UIViewController, we need to take in account UINavigationControllers and UITabViewControllers, we can ignore this ones and get the view controller being presented.

  • For SwiftUI or unconventional navigation systems we should offer a manual API to set the current screen name.

@kahest kahest mentioned this issue Aug 23, 2023
Closed
@brustolin brustolin mentioned this issue Oct 17, 2023
Merged
7 tasks
@brustolin brustolin self-assigned this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brustolin brustolin

Labels
Platform: Cocoa Type: Enhancement
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added screen name to app context getsentry/sentry-cocoa
2 participants
@kahest @brustolin