Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editing GO term of annotations with a NOT qualifier does not function properly #55

Open
krchristie opened this issue Oct 7, 2024 · 3 comments
Assignees
Labels
bug Something isn't working high priority

Comments

@krchristie
Copy link

krchristie commented Oct 7, 2024

@LiNiMGI noticed this behavior and asked me to confirm and submit a ticket if needed.

Using the Standard Annotations editor to edit the GO term of an annotation with a NOT qualifier produces odd and undesirable results.

Here is the Standard Annotations editor with a single NOT annotation shown. Notice the contents of the RELATIONSHIP field: "NOT involved in":
2024_10_07-editingNOTannot-OtherInfo-SA-1

Having edited the TERM field, notice that the contents of the RELATIONSHIP field is now only "involved in" WITHOUT the "NOT":
2024_10_07-editingNOTannot-OtherInfo-SA-2

Clicking the "Save" button in the bar at the top commits the change still missing the "NOT" qualifier in the RELATIONSHIP field:
2024_10_07-editingNOTannot-OtherInfo-SA-3

Looking at the display of the same model in the Graph Editor suggests that the Standard Annotations editor has added the new GO term WITHOUT removing the original GO term and it's associated "NOT" qualifier:
2024_10_07-editingNOTannot-OtherInfo-SA-4

The annotation Preview of this model suggests the same thing as the Graph Editor. Notice the 4th annotation in the table that has "involved_in|NOT" in the Qualifier field, but has the GO ID instead of the term name in the GO Term field:
2024_10_07-editingNOTannot-OtherInfo-SA-5

@krchristie krchristie changed the title editing annotations with a NOT qualifier produces odd results editing annotations with a NOT qualifier produces poor results Oct 7, 2024
@krchristie
Copy link
Author

My test edits of every other editable field of a different NOT annotation in the same model did not produce any problems with the NOT qualifier and the original term it was associated with.

Here is a link to my test model: http://noctua.geneontology.org/editor/graph/gomodel:66f5faaa00000992

@krchristie krchristie changed the title editing annotations with a NOT qualifier produces poor results editing GO term of annotations with a NOT qualifier does not function properly Oct 7, 2024
@vanaukenk vanaukenk self-assigned this Oct 8, 2024
@vanaukenk
Copy link

Thank you for the feedback @krchristie @LiNiMGI

@tmushayahama - can you please look into this bug? Please let me know if you want to look at it together. I can reproduce what Karen and Li are seeing.

@krchristie
Copy link
Author

It's also worth noting that the same behavior occurs in the Noctua-Form editor. I submitted a ticket for that in the noctua-form repository: geneontology/noctua-form#246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Development

No branches or pull requests

3 participants