Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previously selected options in Gene Product autocomplete disappear from list #48

Open
krchristie opened this issue Sep 15, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@krchristie
Copy link

When I click the mouse in the box for the Gene Product field, a list of gene product symbols & IDs that have been used in the model shows up in the dropdown list of autocomplete options. I can use the down arrow to highlight the one I want and the return key to select it. Once I've entered the rest of the details of my annotation, I use the "Save" button to save it and the new annotation shows up in the table of annotations below.

However, now when I click the mouse in the box for the Gene Product field, the list of available options that now appears in the dropdown list of autocomplete options NO LONGER contains the symbol of the gene product that I just made the new annotation for.

Below are two examples.

Example 1 - Dmrtb1 (MGI:MGI:1927125): http://noctua-dev.berkeleybop.org/workbench/noctua-standard-annotations/?model_id=gomodel:MGI_MGI_1927125

Here is the version of the autocomplete list generating by clicking into a freshly opened window for the Dmrtb1 model. Note the presence of two options in the list: "Dmrtb1 Mmus" & "mAPBB1 Mmus"
initialGPautocomplete

Here is the version of the autocomplete list generating by clicking into "Gene Pruduct" box of the Dmrtb1 model after adding a new annotation for "Dmrtb1 Mmus". Note that there is now only one item in the list ("mAPBB1 Mmus"), while the option that I selected ("Dmrtb1 Mmus") for the annotation I just made is now missing from the list of options.
subsequentIncompleteGPautocomplete

Example 1 - KRC test annotations: http://noctua-dev.berkeleybop.org/workbench/noctua-standard-annotations/?model_id=gomodel:66c64f3300000094

Here is the version of the autocomplete list generating by clicking into a freshly opened window for the KRC test annotations model. Note the identify of the five options in the list: "Ift22 Mmus", "Ift20 Mmus", "Ift25 Mmus", "Ift27 Mmus", & "Ift43 Mmus" AND and the presence of scroll bar.
Ift20-presentInAutocomplete

Here is the version of the autocomplete list generating by clicking into "Gene Pruduct" box of the KRC test annotations model after adding a new annotation for "Ift20 Mmus". Note that there are now ONLY five options in the list as there is no longer a scroll bar. "Ift20 Mmus", previously the second item in the list is NO LONGER present. The other four items visible previously are still present in the same order as previously and "Ift88 Mmus", which was previously not visible is now the bottom item in the list.
Ift20-missingFromAutocomplete

@krchristie
Copy link
Author

While on the subject of the autocomplete options that appear when one clicks in the Gene Product box, here are two other things I notice that are odd. I included them here as both refer to the screenshots I've included here, but feel free to move these to separate tickets if that is most appropriate.

1. What is the logic for the order of the items in the autocomplete list?

  • In the KRC test annotations model, I find it odd that "Ift22 Mmus" was listed before "Ift20 Mmus", but the rest of the list is in alphanumeric order. I would prefer a systematic order, e.g. strictly alphanumeric so that it is obvious where to expect to find an item within the list.

2. Is it intentional for "mAPBB1 Mmus" to be included in the options for the "Gene Product" field?

  • The value "mAPBB1 Mmus" was used in the With field, NOT in the Gene Product field. While in this case, it might be reasonable to use "mAPBB1 Mmus" as a Gene Product, MGI uses numerous things in the with field that are NOT reasonable options for the "Gene Product" field, e.g. allele IDs. I think I might prefer if the things that come up in the "Gene Product" autocomplete suggestions are restricted to things actually used in the "Gene Product" field.

@vanaukenk
Copy link

Thanks for the feedback @krchristie
I'll go through the ticket carefully and let you know if we need more discussion.

@vanaukenk vanaukenk added the bug Something isn't working label Sep 16, 2024
@vanaukenk
Copy link

@tmushayahama
How often is the dropdown list of previously annotated entities refreshed?

@krchristie
Copy link
Author

I'll add that I can force the autocomplete to show all options by shift-reloading the webpage.

However, I would strongly prefer if I could just hit the "Save" button and proceed to my next annotation without needing to manually force the autocomplete suggestions to reload or needing to type the gene symbol in to get the gene I need when I am adding another annotation to the same gene I just annotated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants