Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Geany theme #54

Closed
rovf opened this issue Feb 22, 2024 · 7 comments
Closed

Bug in Geany theme #54

rovf opened this issue Feb 22, 2024 · 7 comments

Comments

@rovf
Copy link

rovf commented Feb 22, 2024

MacOS 12.7.3 with Geany 1.38

I'm using the colour scheme called "Metallic Bottle" to edit Ruby programs. The thema is very pleasant to use, but has one problem: It colours Ruby symbols in the same colour, which is also used as the background for highlighting. This means that if I have a statement

`attr_reader :abcd`

and select the :abcd with the mouse, I can't read anything, because foreground and background are the same colour.

I wanted to fix it locally, but can't find the definition file for this thema. BTW, my .config/geany/colorschemes directory is empty; I don't know where the Geany installer put its theme files.

@elextr
Copy link
Member

elextr commented Feb 22, 2024

On Linux its in $PREFIX/share/geany/colorschemes but not sure where it is on Macos.

@techee
Copy link
Member

techee commented Feb 25, 2024

You can either copy it from

/Applications/Geany.app/Contents/Resources/share/geany/colorschemes

or from https://github.com/geany/geany-themes. After its modification you can just copy it under .config/geany/colorschemes.

@rovf
Copy link
Author

rovf commented Feb 26, 2024

I found the theme, but I can't recognize, which setting effects the colouring of Ruby symbols (i.e. a colon, followed by alphanumeric characters). The symbol as such is recognized as syntactic entity, because it is coloured differently; just which setting in the theme file affects this colour?

@techee
Copy link
Member

techee commented Feb 26, 2024

Maybe you don't want to modify the theme but the ruby filetype settings: Tools->Configuration Files->Filetype Configuration->Scripting Languages->filetypes.ruby. Under the [styling] section you apply the colors defined in the theme to the syntactic features of the given language. The commented-out lines are the default assignments.

@rovf
Copy link
Author

rovf commented Feb 26, 2024

Good point. I see that symbols are coloured in the theme as preprocessor. I don't need to change the filetype settings, but simply can set the desired colour in the theme for the token "preprocessor". Thanks a lot. Issue solved for me. Still I think it would be a good idea, if the theme bundled with Geany, would also fix this. Having a syntactic element in the same foreground colour as the selection colour, leads to trouble.

@techee
Copy link
Member

techee commented Feb 26, 2024

The extra themes are taken from https://github.com/geany/geany-themes so you can submit a pull request fixing the bug.

@techee
Copy link
Member

techee commented Mar 8, 2024

Closing here in favor of geany/geany-themes#70

@techee techee closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants