Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcli sc-sast session login: Allow for overriding SC SAST Controller URL #611

Open
rsenden opened this issue Sep 25, 2024 · 0 comments
Open
Labels
effort:low Easy to implement/fix enhancement New feature or request fcli-sc-sast Issue related to 'fcli sc-sast' commands prio:medium Medium priority

Comments

@rsenden
Copy link
Contributor

rsenden commented Sep 25, 2024

Enhancement Request

We currently retrieve the controller URL from SSC, which works fine in most cases unless the controller URL points to some internal DNS/IP or Kubernetes cluster name that is not accessible from the system where fcli is being run.

We should provide an option on the fcli sc-sast session login command to override the controller URL that's being returned by SSC to allow for correct fcli operation in such scenarios.

Alternatively, we could raise an SSC enhancement request to allow both internal and external controller URL to be configured, in which case fcli could use the external controller URL. This would be the preferred approach, as it would avoid the need to explicitly specify the controller URL on each fcli sc-sast session login invocation.

This issue was originally raised at fortify/github-action#47, but since the GitHub Action utilizes fcli for SC SAST connectivity, this needs to be fixed in fcli first.

@rsenden rsenden added enhancement New feature or request fcli-sc-sast Issue related to 'fcli sc-sast' commands prio:medium Medium priority effort:low Easy to implement/fix labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:low Easy to implement/fix enhancement New feature or request fcli-sc-sast Issue related to 'fcli sc-sast' commands prio:medium Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant