Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ff_standings() for MFL significantly diminished #430

Closed
TheMathNinja opened this issue Aug 7, 2024 · 7 comments
Closed

ff_standings() for MFL significantly diminished #430

TheMathNinja opened this issue Aug 7, 2024 · 7 comments

Comments

@TheMathNinja
Copy link
Contributor

TheMathNinja commented Aug 7, 2024

In the past, the ff_standings() function returned potential_points, offensive_points, and defensive_points. But currently, I'm only seeing Points For and Points against in the points readouts. Can we re-include offense, defense, potential for MFL in this function? Thanks!

Additionally (or even instead-of), it would equally help my purposes if ff_schedule() included these numbers on a week-by-week basis.

@tanho63
Copy link
Member

tanho63 commented Aug 7, 2024

Have you modified the standings columns in commissioner settings? I think it’s at least partially impacted by what you select there

@TheMathNinja
Copy link
Contributor Author

I'm seeing that now, yes. Ok, I think this is different than before, but yes it looks constrained by what I choose to have displayed. Is there a way for this function to default to a full readout of all columns that are possible, or to have a full_readout = TRUE argument to have that option?

I guess I'd like ffscrapr to return all 50 variables possible or whatever, but no way I want 50 columns on my MFL standings report.

@tanho63
Copy link
Member

tanho63 commented Aug 7, 2024

please provide output of ffscrapr::ffverse_sitrep()

@TheMathNinja
Copy link
Contributor Author

── System Info ────────────────────────────────────────────────────────────────
• R version 4.4.1 (2024-06-14 ucrt) • Running under: Windows 11 x64 (build 22631)
── Package Status ─────────────────────────────────────────────────────────────
   package installed  cran      dev behind
1 ffscrapr  1.4.8.18 1.4.8 1.4.8.18       
── Package Options ────────────────────────────────────────────────────────────
• No options set for above packages
── Package Dependencies ───────────────────────────────────────────────────────
• askpass    (1.2.0)   • jsonlite   (1.8.8)     • stringr    (1.5.1)  
• assertthat (0.2.1)   • lifecycle  (1.0.4)     • sys        (3.4.2)  
• backports  (1.5.0)   • magrittr   (2.0.3)     • tibble     (3.2.1)  
• cachem     (1.1.0)   • memoise    (2.0.1)     • tidyr      (1.3.1)  
• checkmate  (2.3.1)   • mime       (0.12)      • tidyselect (1.2.1)  
• cli        (3.6.3)   • nflreadr   (1.4.0.12)  • utf8       (1.2.4)  
• cpp11      (0.4.7)   • openssl    (2.2.0)     • vctrs      (0.6.5)  
• curl       (5.2.1)   • pillar     (1.9.0)     • withr      (3.0.0)  
• data.table (1.15.4)  • pkgconfig  (2.0.3)     • graphics   (4.4.1)  
• dplyr      (1.1.4)   • purrr      (1.0.2)     • grDevices  (4.4.1)  
• fansi      (1.0.6)   • R6         (2.5.1)     • methods    (4.4.1)  
• fastmap    (1.2.0)   • rappdirs   (0.3.3)     • stats      (4.4.1)  
• generics   (0.1.3)   • ratelimitr (0.4.1)     • tools      (4.4.1)  
• glue       (1.7.0)   • rlang      (1.1.4)     • utils      (4.4.1)  
• httr       (1.4.7)   • stringi    (1.8.4)       
── Not Installed ──────────────────────────────────────────────────────────────
• ffsimulator  • ffpros  • ffopportunity  

@tanho63
Copy link
Member

tanho63 commented Aug 7, 2024

and reprex?

@TheMathNinja
Copy link
Contributor Author

str(ff_standings(mfl_connect(season = 2022, league_id = 22686, rate_limit_number = 3, rate_limit_seconds = 6)))
tibble [32 × 13] (S3: tbl_df/tbl/data.frame)
 $ franchise_id      : chr [1:32] "0005" "0019" "0027" "0028" ...
 $ franchise_name    : chr [1:32] "Chicago Bears" "New England Patriots" "Jacksonville Jaguars" "Tennessee Titans" ...
 $ h2h_wins          : num [1:32] 17 16 14 15 15 14 14 14 13 12 ...
 $ h2h_losses        : num [1:32] 2 4 5 6 6 7 7 7 7 7 ...
 $ h2h_ties          : num [1:32] 1 1 1 0 0 0 0 0 1 0 ...
 $ h2h_winpct        : num [1:32] 0.875 0.786 0.725 0.714 0.714 0.667 0.667 0.667 0.643 0.632 ...
 $ h2h_wlt           : chr [1:32] "17-2-1" "16-4-1" "14-5-1" "15-6-0" ...
 $ allplay_winpct    : num [1:32] 0.779 0.625 0.746 0.696 0.632 0.669 0.6 0.561 0.602 0.558 ...
 $ allplay_wlt       : chr [1:32] "528-149-1" "424-254-0" "505-172-1" "471-205-2" ...
 $ points_for        : num [1:32] 3974 3617 3891 3619 3660 ...
 $ avg_points_for    : num [1:32] 234 213 229 213 215 ...
 $ avg_points_against: num [1:32] 188 196 206 192 207 ...
 $ streak            : chr [1:32] "L1" "W1" "W3" "L1" ...

Like I said, I've noticed I can expand this if I tell MFL to include more columns in my standings report, but can we get the ff_standings() function to operate such that I can have a trim standings report in MFL but ff_standings() still outputs all possible column variables for MFL standings report (I have only selected maybe 5 of 40 options for columns)

@tanho63
Copy link
Member

tanho63 commented Aug 7, 2024

https://www43.myfantasyleague.com/2022/api_info?STATE=test&CCAT=export&TYPE=leagueStandings&L=22686

if you put the ALL parameter here = 1 or = 0, it returns the same columns, so I think that portion of the API is broken. You may need to open an MFL help ticket demonstrating this

@tanho63 tanho63 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants