-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ff_scoring()
not working for MFL league with thresholdPoints
#413
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Looks like different issue, so reopening this again. Is thresholdPoints a new addition to the scoring for this year? |
ff_scoring()
not working for MFL league with thresholdPoints
Thanks so much for working on this @tanho63! |
Any updates on this one? Is it pretty complex? |
Yeah, somewhat complex. Limiting factor is lack developer time though |
Hey all, |
@rlynch91 Any chance you could get to the bottom of this thing this month? |
Hi all, I haven’t dug too much into this issue since last commenting back in April re my workaround. |
Unsure, you'd need to use git bisect a bunch probably. My guess it's this commit for new dplyr compatibility: b2dc63a This can't be fixed via a reversion, so it'll need to be updated to handle the new dplyr rectangling output. |
Describe the bug
Running ff_playerscores() now returns an error for my MFL league.
Reprex
# Please include the code used for the connection object from `ff_connect()`
Expected behavior
I expect it to return a df, but I'm getting an error:
Error in
dplyr::mutate()
:ℹ In argument:
rule = purrr::map(.data$rule, parse_rule)
.Caused by error in
purrr::map()
:ℹ In index: 10.
Caused by error in
mutate()
:ℹ In argument:
thresholdPoints = (structure(function (..., .x = ..1, .y = ..2, . = ..1) ...
.Caused by error:
!
thresholdPoints
must be size 12 or 1, not 5.Session information
Please copy the output of
ffscrapr::ffverse_sitrep()
into the box below.Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: