Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commas in URL #19

Open
xJon opened this issue Jul 12, 2020 · 3 comments
Open

Commas in URL #19

xJon opened this issue Jul 12, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@xJon
Copy link

xJon commented Jul 12, 2020

Trying to parse a URL with a , in it can mess it up pretty bad:
Screenshot_3
(It detected the first bit, then it stopped, then it detected a bunch of phone numbers).

Is there anything that can be done about this?
Thank you!

@fayeed
Copy link
Owner

fayeed commented Jul 17, 2020

You could setup a custom Regex for this.

I didn't spent much time on the default one that comes bundle with the package so some edge cases could be a problem.

@fayeed fayeed added the bug Something isn't working label Jul 17, 2020
@beheobong
Copy link

MatchText(
                    type: ParsedType.CUSTOM,
                    pattern:
                    r'http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\(\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+',
                    regexOptions: RegexOptions(
                      multiLine: true,
                      dotAll: true
                    ),)

@xJon @fayeed i change pattern and it fixed. You can use it

@pablotardio
Copy link

MatchText(
                    type: ParsedType.CUSTOM,
                    pattern:
                    r'http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\(\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+',
                    regexOptions: RegexOptions(
                      multiLine: true,
                      dotAll: true
                    ),)

@xJon @fayeed i change pattern and it fixed. You can use it

So thanks for the pattern, I had a problem with the "%" T-T

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants