Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

회원가입 구현 #4

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

회원가입 구현 #4

wants to merge 13 commits into from
+569 −254

Conversation

IkJuLim
Copy link
Collaborator

@IkJuLim IkJuLim commented Oct 15, 2024 •
edited
Loading

close #3

@IkJuLim IkJuLim self-assigned this Oct 15, 2024
@IkJuLim IkJuLim linked an issue Oct 15, 2024 that may be closed by this pull request
[Feature] 회원가입 기능 #3
Open
6 tasks
@IkJuLim IkJuLim changed the base branch from main to develop October 15, 2024 18:59
f-lab-jason
f-lab-jason reviewed Oct 17, 2024
View reviewed changes
Copy link

@f-lab-jason f-lab-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현 자체는 잘 하셨네요!
사소한 convention 관련 내용이나 테스트 관련된 내용만 수정하면 좋을 것 같습니다 🙂

ExceptionHandler 같은건 추후에 구현할 계획이 있으신가요?

src/main/java/com/limikju/daangn_market/domain/enums/Role.java Outdated Show resolved Hide resolved
src/main/java/com/limikju/daangn_market/repository/MemberRepository.java Outdated Show resolved Hide resolved
src/main/java/com/limikju/daangn_market/service/MemberService.java Outdated Show resolved Hide resolved
src/test/java/com/limikju/daangn_market/controller/MemberControllerTest.java Outdated Show resolved Hide resolved
@IkJuLim
Copy link
Collaborator Author

IkJuLim commented Oct 17, 2024

구현 자체는 잘 하셨네요! 사소한 convention 관련 내용이나 테스트 관련된 내용만 수정하면 좋을 것 같습니다 🙂

ExceptionHandler 같은건 추후에 구현할 계획이 있으신가요?

ExceptionHandler는 조금 더 개발을 진행하고 도입을 하려고 했습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-jason f-lab-jason f-lab-jason left review comments

Assignees

@IkJuLim IkJuLim

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 회원가입 기능
2 participants
@IkJuLim @f-lab-jason