Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate position accuracy and horizontal accuracy as covariance #98

Open
willdzeng opened this issue Mar 16, 2019 · 2 comments
Open

Populate position accuracy and horizontal accuracy as covariance #98

willdzeng opened this issue Mar 16, 2019 · 2 comments

Comments

@willdzeng
Copy link
Contributor

willdzeng commented Mar 16, 2019

Hi,
Note that right now the driver publishes NavSatFix message but the position covariance are zeors.
I wonder if we can populate the position accuracy and horizontal accuracy as covariance?
I am happy to do this but can you provide some info on how would I do that?
Thanks.

position_covariance: [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]
position_covariance_type: 0
@moooeeeep
Copy link

I've stumbled accross an approach to this here: https://github.com/westpoint-robotics/usma_xsens/blob/master/nodes/mtnode_new.py#L474

Besides that, it seems, you can set the other covariances via rosparam: https://github.com/ethz-asl/ethzasl_xsens_driver/blob/master/nodes/mtnode.py#L96

For a start, I'd suggest to add a parameter to specify the position covariance in the same way as the others.

@fcolas
Copy link
Contributor

fcolas commented Aug 25, 2019

I don't have time nor a device with a GPS to test, thus a PR is welcome (with either solution as long as it makes sense).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants