Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.9.0 requires IDF plugin for projects that doesn't use IDF (RDT-767) #278

Closed
lucasssvaz opened this issue Apr 25, 2024 · 2 comments · Fixed by #279
Closed

Version 1.9.0 requires IDF plugin for projects that doesn't use IDF (RDT-767) #278

lucasssvaz opened this issue Apr 25, 2024 · 2 comments · Fixed by #279
Labels
bug Something isn't working

Comments

@lucasssvaz
Copy link
Contributor

lucasssvaz commented Apr 25, 2024

Describe the bug
The new 1.9.0 version fails to run in projects that doesn't have pytest-embedded-idf installed, even if the project is not related to IDF.

You can see it in our Arduino CI: Build Log

Configuration Files

[pytest]
addopts = --embedded-services esp,arduino

# log related
log_cli = True
log_cli_level = INFO
log_cli_format = %(asctime)s %(levelname)s %(message)s
log_cli_date_format = %Y-%m-%d %H:%M:%S

log_file = test.log
log_file_level = INFO
log_file_format = %(asctime)s %(levelname)s %(message)s
log_file_date_format = %Y-%m-%d %H:%M:%S

To Reproduce
Run a test with --embedded-services esp,arduino and dut fixture for example. It should crash.
For example:

def test_hello_world(dut):
    dut.expect("Hello Arduino!")

Expected behavior
Run the tests normally without the need for the IDF plugin.

Dev Environment (please complete the following information):

  • OS: Ubuntu
  • Python Version 3.10
  • Pytest Version 8.1.1
  • pytest-embedded Version 1.9.0
@lucasssvaz lucasssvaz added the bug Something isn't working label Apr 25, 2024
@github-actions github-actions bot changed the title Version 1.9.0 requires IDF plugin for projects that doesn't use IDF Version 1.9.0 requires IDF plugin for projects that doesn't use IDF (RDT-767) Apr 25, 2024
@hfudev
Copy link
Member

hfudev commented Apr 25, 2024

@lucasssvaz Sorry for this bug. fixing it in #279

also created #280 to avoid future similar bugs.

@hfudev
Copy link
Member

hfudev commented Apr 25, 2024

JFYI, all 1.9.0 versions are yanked now. Will make a bugfix release tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants