Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--new-pass-file and --old-pass-file do not strip \n characters #5

Open
danielcb opened this issue Dec 4, 2023 · 0 comments · May be fixed by #6
Open

--new-pass-file and --old-pass-file do not strip \n characters #5

danielcb opened this issue Dec 4, 2023 · 0 comments · May be fixed by #6

Comments

@danielcb
Copy link

danielcb commented Dec 4, 2023

Hi, thanks for this tool. If passwords are read from files \n characters are not stripped (which --vault-password-file seems to do, so after rekeying everything with the same file, it does not match.

A splitlines()[0] fixes this (line 373, vault2vault.py):

return VaultSecret(infile.read().splitlines()[0])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix no stripping newlines from vault password files enpaul/vault2vault
1 participant
@danielcb