Header based routing

[evstratbg]

Hi there,

I've needed a custom routing, based on request headers, using FastAPI. So, I implemented it, tested and now, I want to contribute to Starlette, so it can be available for everybody

Any cons?

[Kludex]

What's the use case?

[Kludex]

We are questioning the need for this functionality to be in Starlette, as it looks like it can be a third party package.

[evstratbg]

Well, for me it looks very natural, as starlette has already a host based versioning, which is a specific case of a header based versioning. So Id rather implement BaseHeaderRouter and inherit it in Host route, than create a separate package with 1 module, actually

[Kludex]

Well, we try to maintain Starlette as minimal as possible, and as you admitdly said it can be a "package with a single module", then it will be cool if you could do that.

You're more than welcome to create a PR to add the package to our third party section on the documentation, if you think it will benefit others.

[evstratbg]

ok, got it, thank you

last thing I want to clarify. Isnt the Host based routing the part of the Header based routing? if yes, dont you think, that Header based routing should be a part of starlette?

[evstratbg]

@Kludex