Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in nsis-web target for appPackageUrl option #8581

Open
grovesNL opened this issue Oct 10, 2024 · 1 comment
Open

Regression in nsis-web target for appPackageUrl option #8581

grovesNL opened this issue Oct 10, 2024 · 1 comment

Comments

@grovesNL
Copy link
Contributor

  • Electron-Builder Version: 25.0.5
  • Node Version: n/a
  • Electron Version: n/a
  • Electron Type (current, beta, nightly): n/a
  • Target: nsis-web, Windows x64

Since #6964 the appPackageUrl doesn't work as intended because extra paths are appended to the URL, which means it's not possible to download the latest at a single URL (see #7732 for an example).

My understanding is that APP_PACKAGE_URL_IS_INCOMPLETE intentionally tried to skip setting the package name based on architecture, instead using the name specified with appPackageUrl, but #6964 will use the regular naming.

@mmaietta
Copy link
Collaborator

Would you mind sharing a minimum reproducible repo/gist for this issue? I'd like to create a unit test for this

Re: the PR, I'm wondering if it's just safer to revert, but I'd still like to do the unit test to prevent future regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants