Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Renderer - maybe the rankWith example has a to low rank.... #233

Open
rsoika opened this issue Jun 26, 2022 · 2 comments
Open

Custom Renderer - maybe the rankWith example has a to low rank.... #233

rsoika opened this issue Jun 26, 2022 · 2 comments

Comments

@rsoika
Copy link

rsoika commented Jun 26, 2022

In the custom Render Example page the rankedTester uses 3 as the rank for the renderer. This woks fine. But I have noticed that the vanilla ArrayRenderer uses 4. So if you take the example Tester Code you can fail when using the same code for arrays. Maybe its better to change the example rank to something like '99' ?

@sdirix
Copy link
Member

sdirix commented Jun 27, 2022

Probably we should explain on how to derive on a good number. Taking something very large makes sense if you never expect the tester to be overruled by another one.

@rsoika
Copy link
Author

rsoika commented Jun 27, 2022

I think the ranking concept is clear enough. I was only surprised to see the rank 4 in the vanilla array renderer. Maybe you can do a recommendation to take a rank >=10 as ranks <10 are reserved for the jsonForms core implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants