Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non blocking completion #87

Open
nottud opened this issue Apr 14, 2022 · 1 comment
Open

Allow non blocking completion #87

nottud opened this issue Apr 14, 2022 · 1 comment

Comments

@nottud
Copy link

nottud commented Apr 14, 2022

When e(fx)clipse is installed Eclipse content assist non blocking content assist is disabled because it apparently needs the UI thread. The plugin should be updated to remove this requirement.

The setting is under: Java -> Editor -> Content Assist -> Advanced and it is called: Enable non-blocking completion (does not affect open editors)

The area to change is org.eclipse.fx.ide.jdt.ui.id2 (I don't know the exact class)

@danthe1st
Copy link

danthe1st commented Mar 3, 2023

image

The warning occurs as soon as org.eclipse.fx.ide.jdt.ui (JDT UI Tooling for JavaFX) is in the installed plugin list.

The relevant proposal computer is declared here:

<extension
id="id2"
point="org.eclipse.jdt.ui.javaCompletionProposalComputer">
<javaCompletionProposalComputer
activate="true"
categoryId="org.eclipse.jdt.ui.javaAllProposalCategory"
class="org.eclipse.fx.ide.jdt.ui.internal.FXBeanJavaCompletionProposalComputer">
<partition type="__dftl_partition_content_type"/>
<partition
type="__java_string">
</partition>
</javaCompletionProposalComputer>
</extension>

I think adding requiresUIThread="false" to it as done here could fix it but it might have side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants