Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search/filtering to HTML OMD #3

Open
dotMorten opened this issue Mar 20, 2018 · 7 comments
Open

Add search/filtering to HTML OMD #3

dotMorten opened this issue Mar 20, 2018 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dotMorten
Copy link
Owner

It would be useful to be able to quickly filter the HTML diagram by name, namespace, usage etc.

@dotMorten dotMorten added enhancement New feature or request help wanted Extra attention is needed labels Mar 20, 2018
@MarcosMeli
Copy link

MarcosMeli commented Nov 2, 2018

Hi there @dotMorten I can help if you want with this issue
I will implement it with jquery, using the cdn to avoid .js files in the repo and distribution

What do you think about to add an option to create a plain html, like the current one, and a dynamic version with jquery, filtering, collapsing, etc ?

@dotMorten
Copy link
Owner Author

@MarcosMeli One of the requirements is to have a completely encapsulated report. Referencing an external jquery would break that and including jquery just for some basic filtering seems rather overkill.

@Antaris
Copy link

Antaris commented Feb 12, 2019

I have a prototype self-contained search utility that I am happy to do as a new PR @dotMorten?

@dotMorten
Copy link
Owner Author

dotMorten commented Feb 12, 2019

@Antaris That sounds interesting. Do you have an example page I can look at?

Back when this was logged, the layout was even worse, so at least now you can quickly collapse by namespace, which does help a lot.

@Antaris
Copy link

Antaris commented Feb 13, 2019

@dotMorten Here is my example: https://antaris.github.io/OMD-SearchExample/

Still a little rough around the edges, but certainly a start!

@PeterMTaylor
Copy link

@Antaris that example is great I find that much easier to shift my focus/interest on namespace I need with the plus minus on the side to expand and collapse things of interest. One additional feedback would be perhaps a way to have a collapse All and Expand All option at the top instead of the bottom in the next iteration if approved.
I note that you made a link to Github.io with one HTML could I ask how I can set up mine this way, any tips? Thanks.

@dotMorten
Copy link
Owner Author

@Antaris did you want to make a PR for your search feature? Or do you mind I pull it in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants