You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We just upgraded from Rails 5.0.6 to the newly released 5.0.7 and suddenly all of our existing safelisted entries started failing. After taking a look at it, we saw that the version incremented in the deprecation callstack message. Here's the diff that fixed the problem:
- not deprecated: http://api.rubyonrails.org/v5.0.6/classes/ActionController/Parameters.html'+ not deprecated: http://api.rubyonrails.org/v5.0.7/classes/ActionController/Parameters.html'
What do you think about adding some kind of tolerance for that version number to make bugfix upgrades easier?
I'd be willing to make a PR for something like this if it aligns with you!
The text was updated successfully, but these errors were encountered:
Sorry for the delay - this sounds like a good idea, I'd be happy to accept such a feature!
I did add support for matching prefixes only for a similar reason, if I remember correctly. It meant I could leave out some of the overly specific URLs etc. from messages if needed, this might be a useful workaround for you too.
We just upgraded from Rails 5.0.6 to the newly released 5.0.7 and suddenly all of our existing safelisted entries started failing. After taking a look at it, we saw that the version incremented in the deprecation callstack message. Here's the diff that fixed the problem:
What do you think about adding some kind of tolerance for that version number to make bugfix upgrades easier?
I'd be willing to make a PR for something like this if it aligns with you!
The text was updated successfully, but these errors were encountered: