Skip to content
This repository has been archived by the owner on Mar 20, 2019. It is now read-only.

Add confirmation when closing a group #9

Closed
SuperTux88 opened this issue Nov 20, 2015 · 12 comments
Closed

Add confirmation when closing a group #9

SuperTux88 opened this issue Nov 20, 2015 · 12 comments
Labels
feature
Milestone
0.6.0

Comments

@SuperTux88
Copy link
Contributor

No description provided.

@denschub denschub modified the milestone: 0.2.0 Nov 20, 2015
@Swatinem
Copy link

👍
Or alternative provide an undo action.
I just accidently closed a whole group and actually had to mess around with the sessionrestore data to get it back. That was a really terrifying experience tbh :-D

@denschub denschub modified the milestones: 0.2.0, 0.3.0 Feb 12, 2016
@SuperTux88 SuperTux88 mentioned this issue Mar 11, 2016
Closed
@hheimbuerger
Copy link

I'm running 0.3.0, but was this feature actually released in that? Any documentation on how to invoke it? Or is the milestone incorrect?

@denschub
Copy link
Owner

This issue is still open, which means it's not implemented yet.

@hheimbuerger
Copy link

@denschub Yes, but it's also flagged as "Milestone 0.3.0", which is already released. So one of these two data points has to be incorrect. :)

@denschub
Copy link
Owner

Better now?

@hheimbuerger
Copy link

@denschub Cheers! :)

xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 2, 2016
@xiio
denschub#9 Add confirmation when closing a group
7449206
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 3, 2016
@xiio
denschub#9 code review fixes
028ccba
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 3, 2016
@xiio
denschub#9 added missing .length
00bc16c
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 Add confirmation when closing a group
60ead53
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 code review fixes
54f73a1
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 added missing .length
2302e8a
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 better closing group confirmation
380758d
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 Add confirmation when closing a group
652cce4
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 code review fixes
771ea69
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 added missing .length
471fa27
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 Add confirmation when closing a group
e89a2c6
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 code review fixes
ade266b
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 added missing .length
e573284
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 better closing group confirmation
6b1bd8c
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Apr 10, 2016
@xiio
denschub#9 Add confirmation when closing a group
1a599d1
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Jun 8, 2016
@xiio
denschub#9 Add confirmation when closing a group
fbcb721 
 - counter removed
 - default group delay sets to 3
 - lint fixes
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Sep 17, 2016
@xiio
denschub#9 Add confirmation when closing a group
7fd6704 
 - dead code elimination
xiio added a commit to xiio/firefox-tabgroups that referenced this issue Sep 17, 2016
@xiio
denschub#9 Add confirmation when closing a group
b55add5 
 - dead code elimination
@ghost ghost mentioned this issue Oct 12, 2016
Open
denschub pushed a commit that referenced this issue Oct 25, 2016
@xiio @denschub
#9 Add confirmation when closing a group
526eab2
@denschub denschub modified the milestones: 0.5.0, 0.6.0 Oct 25, 2016
denschub pushed a commit that referenced this issue Jan 15, 2017
@xiio @denschub
Issue #9 - Add timeout when closing a group
3a869eb
@denschub
Copy link
Owner

Technically solved by #34.

@aaronraimist
Copy link

How long until you expect 0.6.0 will be released with this feature?

@denschub
Copy link
Owner

@aaronraimist meh, sorry. I'm busy with work. Will try to ship the release next week, I promise!

@whiskytroll
Copy link

I'm sorry if I'm being dense, but is this feature about restoring groups or adding a confirmation when closing groups or both? Additionally it would be nice to know when it's being rolled out?

@denschub denschub mentioned this issue Oct 21, 2017
Closed
@denschub
Copy link
Owner

but is this feature about restoring groups or adding a confirmation when closing groups or both?

You can restore closed groups within a defined period of time.

Additionally it would be nice to know when it's being rolled out?

#60.

@whiskytroll
Copy link

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
6 participants
@hheimbuerger @denschub @SuperTux88 @Swatinem @aaronraimist @whiskytroll