diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a59db7f..3860f8a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,6 +17,7 @@ jobs: test: runs-on: ubuntu-latest strategy: + fail-fast: false matrix: DENO_VERSION: - v1.x diff --git a/src/connection.ts b/src/connection.ts index cdeb17c..3f2b23f 100644 --- a/src/connection.ts +++ b/src/connection.ts @@ -341,11 +341,7 @@ export class Connection { if (!iterator) { while (true) { receive = await this.nextPacket(); - // OK_Packet when CLIENT_DEPRECATE_EOF is set. OK_Packet can be 0xfe or 0x00 - if ( - receive.type === PacketType.EOF_Packet || - receive.type === PacketType.OK_Packet - ) { + if (receive.type === PacketType.EOF_Packet) { break; } else { const row = parseRow(receive.body, fields); diff --git a/test.ts b/test.ts index a41ccb6..e030e8c 100644 --- a/test.ts +++ b/test.ts @@ -337,6 +337,21 @@ testWithClient(async function testDropUserWithMysqlNativePassword(client) { await client.execute(`DROP USER 'testuser'@'%'`); }); +testWithClient(async function testSelectEmptyString(client) { + assertEquals( + await client.query(`SELECT '' AS a`), + [{ a: "" }], + ); + assertEquals( + await client.query(`SELECT '' AS a, '' AS b, '' AS c`), + [{ a: "", b: "", c: "" }], + ); + assertEquals( + await client.query(`SELECT '' AS a, 'b' AS b, '' AS c`), + [{ a: "", b: "b", c: "" }], + ); +}); + registerTests(); Deno.test("configLogger()", async () => {