Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook should send error status code on wrong passkey #1408

Open
tricki opened this issue Feb 15, 2024 · 0 comments
Open

Webhook should send error status code on wrong passkey #1408

tricki opened this issue Feb 15, 2024 · 0 comments
Labels

Comments

@tricki
Copy link

tricki commented Feb 15, 2024

Description

When trying to call a feed's webhook with a wrong passphrase, the response is HTML and has a 200 status code. To make it easier to detect such errors, an error status code such as 401 should be returned.

Ideally the response would also respect the "Accepts" header and send JSON when requested.

Steps to reproduce

  1. Create an import
  2. Call its webhook with a wrong or missing passkey.

Additional info

  • Craft version: Craft Pro 4.5.13
  • PHP version: 8.0.30
  • Database driver & version: n/a
  • Plugins & versions: Feed Me | 5.3.0
@tricki tricki added the bug label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant