You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@lukeholder On our non-Craft Commerce projects, we use https://github.com/moneyphp/money which helps abstract away most of the logic. It still takes careful consideration across the board when working with money, as usual.
@adrum Thanks, we are using Money in Commerce 5 and it's new Teller class for managing floating point number comparisons until we move to Money objects for all values. I will look to backport these changes to Commerce 4.
@lukeholder Have you given any more attention to this particular issue? We came across an issue in production where this caused an order to be "partially paid" when it should've been just "paid", and wasn't sure what to expect on this front.
What happened?
Description
Please put any information on any floating point number comparison issues in the comments below.
Related issues:
#1836
Related PRs:
#3385
Craft CMS version
4.x
Craft Commerce version
4.x
PHP version
No response
Operating system and version
No response
Database type and version
No response
Image driver and version
No response
Installed plugins and versions
The text was updated successfully, but these errors were encountered: