Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload command and Docker images #7

Open
vincenzobaz opened this issue Dec 3, 2020 · 8 comments
Open

Upload command and Docker images #7

vincenzobaz opened this issue Dec 3, 2020 · 8 comments

Comments

@vincenzobaz
Copy link
Contributor

The upload command does not accept a Docker image id anymore.

  • What is the recommended procedure to create the zip image from a docker image ?
  • The command still accepts a --temp-dir flag Temporary directory to use when exporting the container.. Is this needed ?
@echuber2
Copy link
Contributor

echuber2 commented Dec 4, 2020

I assume the zip just needs to contain the Dockerfile and the rest of the build context directory in its root. This is how it works when you upload build files through the site.

@vincenzobaz
Copy link
Contributor Author

Thank you !
Do you download data during the creation of the docker image ? (I am wondering whether the image creation process has internet access).

I wish I could give the same input to grade local and upload so that grade local truly tests what will happen on the servers...

@sashi-coursera
Copy link
Contributor

Thank you @echuber2 for your speedy comment to help @vincenzobaz .

We understand grade local and upload do not take the same input. We were trying to support this SDK with minimal changes possible, while trying to innovate in our platform. Appreciate the feedback. We always welcome any PRs and would happy to do a quick review.

@echuber2
Copy link
Contributor

Do you download data during the creation of the docker image ? (I am wondering whether the image creation process has internet access).

Sorry, I missed this question. Yes, the Docker build step can access the internet while it builds on Coursera's server.

@MidnightEmpire
Copy link
Contributor

MidnightEmpire commented Jan 9, 2021

Hello. I also have some questions (after reading messages above) :)

  1. May docker image still be useful for uploading, or only zip archive build now is the only proper way to perform grader upload?
  2. (If docker image now is useless in uploading process in general). Is these steps proper ones to upload:
  • Build single zip file of custom grader root directory (which one contains Dockerfile);
  • Specify path to this zip into imageZipFile key;
  • All other keys/flags may be same as for (old) courseraprogramming;
  • Run coursera_autograder with keys/flags as mentioned above;
  • (Finally) coursera_autograder run provide further uploading process?
    :)

@sashi-coursera
Copy link
Contributor

sashi-coursera commented Jan 9, 2021

@MidnightEmpire

  1. Only zip with Dockerfile and associated grader files. Basically all the files required to build docker image on the coursera server. Make sure you are in the directory containing the Dockerfile. This must be the top level directory.
  2. Yes, rest is pretty much the same as courseraprogramming. Please let us know if you are running into any issues.

@MidnightEmpire
Copy link
Contributor

1. Only zip with Dockerfile and associated grader files. Basically all the files required to build docker image on the coursera server. Make sure you are in the directory containing the Dockerfile. This must be the top level directory.

2. Yes, rest is pretty much the same as courseraprogramming. Please let us know if you are running into any issues.

Finally, i made these steps: (as mentioned above)
a) made zip archive for folder with dockerfile
b) Specify path to this zip into imageZipFile key
c) Run coursera_autograder uploading

...after these steps i got SUCCESS state, and saw my zip archive available in the popup combobox of any programming task of my course.
BUT!
~15-20 minutes later my zip archive disappear in the popup combobox of any programming task of my course: only older courses list (docker images) available....
May you help me - what may be the reason of this? :)

@sashi-coursera
Copy link
Contributor

@MidnightEmpire : Could you please reach out to coursera partner support with these details and the zip archive that is giving the problem? Please let me know if you need help with this.

Also, I am wondering if you were able to use any samples successfully : https://github.com/coursera/programming-assignments-demo/tree/master/custom-graders/v2 , to rule out any common issues with your testing/setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants