Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to docker package #16

Open
Dekker1 opened this issue Jan 20, 2021 · 3 comments · May be fixed by #41
Open

Update to docker package #16

Dekker1 opened this issue Jan 20, 2021 · 3 comments · May be fixed by #41

Comments

@Dekker1
Copy link

Dekker1 commented Jan 20, 2021

I'm upgrading the docker graders for my course and would love to use more of the architecture provided by Coursera. However, I currently cannot run any of the running/testing environment.

It seems that the interaction with Docker is based around a package called docker-py (version 1.10.4) which is incompatible with the current version of Docker on MacOS. Currently my grader has some pytest testing which uses the docker package (version 4.4.1), which does seem to work.

I had a quick look and it looks like both packages point to the same repository, but that the former was discontinued and replaced by the latter. It would be great if you could upgrade the package to use this newer version so it is usable on more systems.

@sashi-coursera
Copy link
Contributor

Hi Dekker1,

It is not clear to me. Are you requesting us to upgrader docker-py version? I believe we can update the version in setup.py. I appreciate making changes locally and verify the expected behavior. It looks like the next docker-py version is 1.10.6. Also what is your docker version on your MacOS?

Please feel free to create a PR and we will review/test them soon.

Thank you,
Sashi.

@Dekker1
Copy link
Author

Dekker1 commented Jan 21, 2021

Hi Sashi,

I'm running Docker version 3.1.0 on macOS Big Sur.

What I'm referring to is not just to update the docker-py package from PyPI (https://pypi.org/project/docker-py/), which was last updated more than 4 years ago, but to switch to the newer docker package (https://pypi.org/project/docker/), which received updates until a month ago. On PyPI both packages refer to the same source location so I assume that the docker-py package is a deprecated version of the newer docker package.

@echuber2
Copy link
Contributor

echuber2 commented Feb 1, 2021

I made a PR in #18 you might want to try. It uses the new docker package. @Dekker1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants