Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take the checkPhase into account in CI runs #219

Open
CohenCyril opened this issue May 28, 2024 · 0 comments
Open

Take the checkPhase into account in CI runs #219

CohenCyril opened this issue May 28, 2024 · 0 comments

Comments

@CohenCyril
Copy link
Collaborator

CohenCyril commented May 28, 2024 •
edited
Loading

I think all packages which have a test-suite should be complemented with a checkPhase attribute and the we should indeed make sure the CI does a doCheck = true for every single derivation, so that we do not have to make local overrides...
cf https://nixos.org/manual/nixpkgs/stable/#ssec-check-phase

Originally posted by @CohenCyril in math-comp/math-comp#1219 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CohenCyril