Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page issues #128

Closed
7 tasks done
artberger opened this issue Nov 6, 2023 · 4 comments
Closed
7 tasks done

Landing page issues #128

artberger opened this issue Nov 6, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@artberger
Copy link

artberger commented Nov 6, 2023

Past Issues Searched

  • I have searched open and closed issues to make sure that the bug has not yet been reported

Issue is a Bug Report

  • This is a bug report and not a feature request, nor asking for support

Describe the bug

I was trying out the landing.yaml to use it as the landing page for our doc set, and ran into some issues.

  • Can’t have book icon in upper left to logo and link to main website (e.g., I’m on docs.solo.io and want this to go back to solo.io)
  • Can’t have the CTA buttons as anchors to content further down the page.
  • Can’t add anchors to sections further down the page. At least I tried adding yaml fields for anchors and it didn't seem to do anything.
  • Can’t have more than one feature section for different collections of docs. It errors or only displays one of the feature sections.
  • In the feature section, can’t click or add a button to go to a page with more info.

Related but different issues:

Expected behavior

See the previous list, which I expected based on common landing page patterns.

Screenshots

No response

Environment

- OS: MacOS
- Browser: brave, chrome, safari
- Browser Version: Brave Version 1.58.137, Chromium: 117.0.5938.153, Safari 16.6
@colinwilson colinwilson added this to the v0.2.0 milestone Nov 7, 2023
@colinwilson colinwilson added enhancement New feature or request good first issue Good for newcomers labels Nov 7, 2023
@colinwilson colinwilson self-assigned this Nov 7, 2023
@colinwilson
Copy link
Owner

@artberger Thanks for this. 👍

I plan to have all the tasks you listed addressed in an update scheduled for Sunday coming.

Can’t have more than one feature section for different collections of docs. It errors or only displays one of the feature sections.

Can you expand on this task a little bit? I'm not sure I understand 100%.

@artberger
Copy link
Author

@colinwilson thank you for the update!

For the features, we have a couple sets of docs and wanted to have both of them. So right now, I can get something like this for a Gloo Gateway collection:

image

But I thought adding another one for Gloo Mesh, such as:

image

It doesn't seem I can get them both to show up at the same time; i. e., you can only have one features list on the landing page.

@colinwilson
Copy link
Owner

colinwilson commented Nov 7, 2023

Thanks for clarifying. 👍

Yes! This is exactly what I'm working on rectifying. It will involve a small breaking change to how the sections are defined in the landing.yaml data file, but will allow any landing 'section' template to be used multiple times.

@colinwilson
Copy link
Owner

Fixed by #132, #133, #134, #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants