Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FastSim] Possible out-of-bounds in CaloDirectionOperations::add2d #46452

Open
iarspider opened this issue Oct 18, 2024 · 5 comments
Open

[FastSim] Possible out-of-bounds in CaloDirectionOperations::add2d #46452

iarspider opened this issue Oct 18, 2024 · 5 comments
Labels
fastsim-pending pending-signatures

Comments

@iarspider
Copy link
Contributor

As noticed by LLVM analyzer in #46421 (comment), the code at https://github.com/cms-sw/cmssw/blob/master/FastSimulation/CaloGeometryTools/src/CaloDirectionOperations.cc#L10 can access array item outside of array bounds if either dir1 or dir2 is UP or DOWN (corresponding to indices 4 or 5).
@iarspider
Copy link
Contributor Author

assign fastsim

@cmsbuild
Copy link
Contributor

New categories assigned: fastsim

@civanch,@kpedro88,@mdhildreth,@ssekmen you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

@kpedro88 as discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fastsim-pending pending-signatures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iarspider @cmsbuild