Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UBSAN] Workflow 29634.402 with infinite loop #46383

Open
smuzaffar opened this issue Oct 15, 2024 · 9 comments
Open

[UBSAN] Workflow 29634.402 with infinite loop #46383

smuzaffar opened this issue Oct 15, 2024 · 9 comments

Comments

@smuzaffar
Copy link
Contributor

smuzaffar commented Oct 15, 2024

UBSAN IB shows that for workflow 29634.402 (step2 and step3) , there are runtime errors like [a]. It looks like this happens when qbin and cp.qBin_ at https://github.com/cms-sw/cmssw/blob/master/RecoLocalTracker/SiPixelRecHits/src/PixelCPEFastParamsHost.cc#L231 are 0. I added a print statement just above this line and after some iterations both qbin and cp.qBin_ become 0. [b]

@cms-sw/reconstruction-l2 , can you please look in to this?

[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/ubsan_logs/CMSSW_14_2_X_2024-10-11-2300/logs/1a/1a1482b8017213202899d1fd0678ab76/log

29634.402/step2:RecoLocalTracker/SiPixelRecHits/src/PixelCPEFastParamsHost.cc:229:16: runtime error: signed integer overflow: 1000 + 2147483000 cannot be represented in type 'int'
29634.402/step3:RecoLocalTracker/SiPixelRecHits/src/PixelCPEFastParamsHost.cc:229:16: runtime error: signed integer overflow: 1000 + 2147483000 cannot be represented in type 'int'

[b]

+      std::cout <<"SMA:"<<k<<":"<<qclus<<","<<qClusIncrement<<","<<cp.qBin_<<"=="<<qbin<<std::endl;

and I see in logs

SMA:0:5500,100,5==5
SMA:0:5600,100,5==5
SMA:0:5700,100,5==5
SMA:0:5800,100,5==5
SMA:0:5900,100,5==5
SMA:0:6000,100,5==5
SMA:1:7000,1000,3==3
SMA:1:8000,1000,3==3
SMA:1:9000,1000,3==3
SMA:1:10000,1000,3==3
SMA:1:11000,1000,3==3
SMA:1:12000,1000,3==3
SMA:1:13000,1000,3==3
SMA:2:14000,1000,2==2
SMA:2:15000,1000,2==2
SMA:3:16000,1000,1==1
SMA:3:17000,1000,1==1
SMA:3:18000,1000,1==1
SMA:3:19000,1000,1==1
SMA:3:20000,1000,1==1
SMA:3:21000,1000,1==1
SMA:3:22000,1000,1==1
SMA:4:23000,1000,0==0
SMA:4:24000,1000,0==0
SMA:4:25000,1000,0==0
SMA:4:26000,1000,0==0
SMA:4:27000,1000,0==0
SMA:4:28000,1000,0==0
SMA:4:29000,1000,0==0
SMA:4:30000,1000,0==0
SMA:4:31000,1000,0==0
SMA:4:32000,1000,0==0
....
....
SMA:4:2147480000,1000,0==0
SMA:4:2147481000,1000,0==0
SMA:4:2147482000,1000,0==0
SMA:4:2147483000,1000,0==0
src/RecoLocalTracker/SiPixelRecHits/src/PixelCPEFastParamsHost.cc:229:16: runtime error: signed integer overflow: 2147483000 + 1000 cannot be represented in type 'int'
    #0 0x7fb156a02bd1 in PixelCPEFastParamsHost<pixelTopology::Phase2>::fillParamsForDevice() src/RecoLocalTracker/SiPixelRecHits/src/PixelCPEFastParamsHost.cc:229
@smuzaffar
Copy link
Contributor Author

assign reconstruction

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@jfernan2,@mandrenguyen you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @smuzaffar.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

@tsusa as PixelTracker contact, could you please have a look and provide a fix? Thanks

@jfernan2
Copy link
Contributor

@ferencek @mroguljic as Pixel Offline conveners, FYI too

@makortel
Copy link
Contributor

assign upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade

@Moanwar,@srimanob,@subirsarkar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@smuzaffar
Copy link
Contributor Author

#46392 shoudl fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants