Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include CSS for fonts #15

Open
twagoo opened this issue Jan 23, 2017 · 0 comments
Open

Include CSS for fonts #15

twagoo opened this issue Jan 23, 2017 · 0 comments

Comments

@twagoo
Copy link
Member

twagoo commented Jan 23, 2017

Currently any page or application has to include the following headers to properly use the theme:

<link href='https://fonts.googleapis.com/css?family=Source+Sans+Pro' rel='stylesheet' type='text/css' />
<link href='https://fonts.googleapis.com/css?family=Roboto+Slab' rel='stylesheet' type='text/css' />

The content of these CSS files can probably be integrated into the style, however there may be XSS issues (see e.g. this blog post), which need to be investigated.

Until then, document the requirement of linking in the font CSS files!
twagoo added a commit that referenced this issue Mar 13, 2017
@twagoo
Update README.md
f592a03 
Instructions for fonts, and a warning about making changes to the CSS.
Refs #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twagoo