Night #10
Replies: 1 comment 8 replies
-
|
It would definitely be possible, just a bit more tricky since it would need to account for the day number change at midnight. This is probably something that I'd be happy to point a developer in the right direction for, but I don't know if I'd have the capacity to maintain it myself. If anyone wants to develop this either as part of the existing file, or a separate file and make a PR I'd be happy to share this repo for that. I'll leave this open as an idea for anyone interested. |
Beta Was this translation helpful? Give feedback.
-
|
Glad to hear you had success with that– you are definitely free to play around with the code and do whatever you want with it! Feel free to make a PR after you've polished the code to your satisfaction and I'd be happy to include that file it in this repo alongside the daylight version. |
Beta Was this translation helpful? Give feedback.
-
|
Cool, will try to do so this week! |
Beta Was this translation helpful? Give feedback.
-
|
@chrisblakley Chris, my gitflow is a little rusty. I wanted to created a branch from your repo, but I can't seem to do so. I think I can create a fork though. Is that what you need me to do? And then create a pull request from that fork? I did create an issue just now (#16) from the discussion topic, because I figured that would be the way to go in order to link it to my branch/fork. Please advise. |
Beta Was this translation helpful? Give feedback.
-
|
That is correct– you can fork the entire repo, push your commit to that forked branch and then when it's ready you can make a pull request that I can merge here. |
Beta Was this translation helpful? Give feedback.
-
|
Done #17 |
Beta Was this translation helpful? Give feedback.
-
Is it possible to create the opposite function, i.e. calendar entries showing night?
Beta Was this translation helpful? Give feedback.
All reactions