From 246ecfae85a0ec065c250c274e415c2253b69b19 Mon Sep 17 00:00:00 2001 From: Alex Li Date: Mon, 14 Aug 2023 00:30:12 +0800 Subject: [PATCH] Remove `Options.compose(options)` (#1935) Removes the accidentally added `options` argument for `Options.compose` by 75cf9166c3d5d159895de123e24a9ce748804a1a. Resolves #1934. ### New Pull Request Checklist - [x] I have read the [Documentation](https://pub.dev/documentation/dio/latest/) - [x] I have searched for a similar pull request in the [project](https://github.com/cfug/dio/pulls) and found none - [x] I have updated this branch with the latest `main` branch to avoid conflicts (via merge from master or rebase) - [ ] I have added the required tests to prove the fix/feature I'm adding - [ ] I have updated the documentation (if necessary) - [x] I have run the tests without failures - [x] I have updated the `CHANGELOG.md` in the corresponding package --------- Signed-off-by: Alex Li --- dio/CHANGELOG.md | 1 + dio/lib/src/options.dart | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/dio/CHANGELOG.md b/dio/CHANGELOG.md index db72361d5..53a80ab6c 100644 --- a/dio/CHANGELOG.md +++ b/dio/CHANGELOG.md @@ -6,6 +6,7 @@ See the [Migration Guide][] for the complete breaking changes list.** ## Unreleased - Fix failing requests throw `DioException`s with `.unknown` instead of `.connectionError` on `SocketException`. +- Removes the accidentally added `options` argument for `Options.compose`. ## 5.3.2 diff --git a/dio/lib/src/options.dart b/dio/lib/src/options.dart index 3e0314fcf..c4aa0c2eb 100644 --- a/dio/lib/src/options.dart +++ b/dio/lib/src/options.dart @@ -294,7 +294,6 @@ class Options { Object? data, Map? queryParameters, CancelToken? cancelToken, - Options? options, ProgressCallback? onSendProgress, ProgressCallback? onReceiveProgress, StackTrace? sourceStackTrace,