Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If image upload errors, ready remains false #48

Open
sweetro opened this issue Oct 18, 2019 · 1 comment
Open

If image upload errors, ready remains false #48

sweetro opened this issue Oct 18, 2019 · 1 comment

Comments

@sweetro
Copy link

sweetro commented Oct 18, 2019

The library works great, but I'm noticing that, while using the DirectUploadProvider if one of my uploads receives an error response from the server, the ready prop remains false.

I believe it is do to the fact that the Promise.all rejects and then uploading: false is never set

const signedIds = await Promise.all(
, making it unable to try the upload again.

Perhaps I'm missing a prop or an approach to handle this case - has anyone else ran into this? Perhaps there should be an onError function that can call during the direct upload if one of the uploads fails.

@leom806
Copy link

leom806 commented May 8, 2024

Happening here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants