Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some tests fail for branch 7.5 on arm64 #34

Open
dotstar-6 opened this issue Apr 16, 2024 · 2 comments
Open

some tests fail for branch 7.5 on arm64 #34

dotstar-6 opened this issue Apr 16, 2024 · 2 comments
Assignees
Labels

Comments

@dotstar-6
Copy link

Hi! I got some test failing (7 of 22) on arm64 am including the test-suite.log

test-suite.log

Was trying on some other release like above is using focal.

@carlosabalde
Copy link
Owner

carlosabalde commented Apr 16, 2024

Thanks for reporting, but for now the VMOD has only been tested and deployed on 64bit systems with Intel or AMD processors (x64). In any case, I'll try to take a look just in case is some kind of easy fix.

@carlosabalde
Copy link
Owner

carlosabalde commented May 29, 2024

@dotstar-6, first of all, sorry for taking so long to get back to you. I've been finally able to take a look at this today and I found two ARM64 issues breaking the automated tests:

  • JSON encoding was inconsistent between ARM64 and x86_64 due to the different default signedness of the char type. Second time this year I've been bitten by this.

  • Usage of Lua's Light Userdata to transport pointers between C and Lua code results in undefined behavior on architectures like ARM64.

Both of them have been fixed in branch fix-lua-lightuserdata-arm64, forked from master. I've tested it on a precarious emulated ARM64 environment and it seems to work fine. Could you please give it a try on your environment? Disclaimer: as I said, the VMOD has only been used in production on x86_64, so I can't guarantee you'll find no other issues on ARM64 :)

@carlosabalde carlosabalde self-assigned this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants