Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Development should have webpack static compilation turned on #541

Open
wtrocki opened this issue Jun 2, 2021 · 5 comments
Open

Development should have webpack static compilation turned on #541

wtrocki opened this issue Jun 2, 2021 · 5 comments

Comments

@wtrocki
Copy link
Contributor

wtrocki commented Jun 2, 2021

This flag might be removed for the development profile to catch up typescript issues.
There are +40 issues currently on master that can be easily fixed

https://github.com/bf2fc6cc711aee1a0c2a/kas-ui/blob/sdk-integration/webpack.common.js#L28:L28

@wtrocki
Copy link
Contributor Author

wtrocki commented Jun 2, 2021

CC @ajaypratap003

@pmuir
Copy link
Contributor

pmuir commented Jun 2, 2021

cc @redallen @jschuler

@wtrocki
Copy link
Contributor Author

wtrocki commented Jun 4, 2021

@pmuir main is broken with updates that would not compile if this flag was setup.
I'm happy to do PR to fix this:

https://github.com/bf2fc6cc711aee1a0c2a/kas-ui/blame/main/webpack.common.js#L28:L28

@pmuir
Copy link
Contributor

pmuir commented Jun 4, 2021

Please do.

@wtrocki
Copy link
Contributor Author

wtrocki commented Jun 4, 2021

@ajaypratap003 will look as there is +40 errors that are patternfly related etc.
We fix problem on main branch already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants