Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of grpc_health_probe command #333

Open
tstirrat15 opened this issue Aug 6, 2024 · 0 comments
Open

Configuration of grpc_health_probe command #333

tstirrat15 opened this issue Aug 6, 2024 · 0 comments

Comments

@tstirrat15
Copy link

The operator has liveness and readiness probes configured. However, the timeout on that probe is a bit misleading, because that's the timeout of the invocation of the command, rather than a timeout that's used by the command itself.

The command is defined here, and the timeout can be configured by flags but there is not currently a flag on the operator for that.

It'd be nice to make the timeouts agree with each other for clarity's sake, and it might be nice to make the probe configurable (though understanding that 1s is a long time for a gRPC connection to be established).

Discord thread for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant