From a012272271f733ef2e918abd5eed794a252cd552 Mon Sep 17 00:00:00 2001 From: Yang Zhou Date: Sun, 23 Jun 2024 23:53:30 -0400 Subject: [PATCH] fix deprecated header file in humble and jazzy (#10) * fix deprecated header file in humble and jazzy * fix the memory leak bug! no more random crash of rviz2 --- waypoint_navigation_plugin/cmake/ROS2.cmake | 1 + waypoint_navigation_plugin/package.xml | 1 + waypoint_navigation_plugin/src/waypoint_nav_frame_ros2.hpp | 2 +- waypoint_navigation_plugin/src/waypoint_nav_tool_ros2.cpp | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/waypoint_navigation_plugin/cmake/ROS2.cmake b/waypoint_navigation_plugin/cmake/ROS2.cmake index 7ab3fb9..7f85f5e 100644 --- a/waypoint_navigation_plugin/cmake/ROS2.cmake +++ b/waypoint_navigation_plugin/cmake/ROS2.cmake @@ -21,6 +21,7 @@ find_package(rviz_common REQUIRED) find_package(rviz_default_plugins REQUIRED) find_package(rviz_rendering REQUIRED) find_package(rosbag2_cpp REQUIRED) +find_package(rosbag2_storage REQUIRED) find_package(mav_manager_srv REQUIRED) find_package(rviz_ogre_vendor REQUIRED) find_package(std_srvs REQUIRED) diff --git a/waypoint_navigation_plugin/package.xml b/waypoint_navigation_plugin/package.xml index 45ba4c5..ec35723 100644 --- a/waypoint_navigation_plugin/package.xml +++ b/waypoint_navigation_plugin/package.xml @@ -24,6 +24,7 @@ rviz_rendering sensor_msgs rosbag2_cpp + rosbag2_storage mav_manager_srv qtbase5-dev diff --git a/waypoint_navigation_plugin/src/waypoint_nav_frame_ros2.hpp b/waypoint_navigation_plugin/src/waypoint_nav_frame_ros2.hpp index 4701d69..e7a28bf 100644 --- a/waypoint_navigation_plugin/src/waypoint_nav_frame_ros2.hpp +++ b/waypoint_navigation_plugin/src/waypoint_nav_frame_ros2.hpp @@ -65,7 +65,7 @@ #include #include #include -#include +#include #include typedef struct { diff --git a/waypoint_navigation_plugin/src/waypoint_nav_tool_ros2.cpp b/waypoint_navigation_plugin/src/waypoint_nav_tool_ros2.cpp index 83b67be..885967f 100644 --- a/waypoint_navigation_plugin/src/waypoint_nav_tool_ros2.cpp +++ b/waypoint_navigation_plugin/src/waypoint_nav_tool_ros2.cpp @@ -72,6 +72,7 @@ WaypointNavTool::~WaypointNavTool() delete frame_; delete frame_dock_; + delete moving_flag_node_; } void WaypointNavTool::onInitialize()