Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still considering outdated reviews #13

Open
nafur opened this issue May 26, 2021 · 2 comments
Open

Still considering outdated reviews #13

nafur opened this issue May 26, 2021 · 2 comments

Comments

@nafur
Copy link
Contributor

nafur commented May 26, 2021

We are seeing that this action does not properly update PRs with the following reviews (in chronological order):

  1. Commenting, User A
  2. Request Changes, User B
  3. Approve, User A
  4. Approve, User B

This is the case that I tried to fix with #11, but somehow it does not work in some cases. (or does not work at all? I'm not sure, actually).

For an example in the wild: cvc5/cvc5#6617 and the job https://github.com/cvc5/cvc5/runs/2672214302?check_suite_focus=true#step:2:9

@nafur
Copy link
Contributor Author

nafur commented May 26, 2021

I've tried to debug this (https://github.com/nafur/update-pr-branch), but this just seems to work as expected.
I'm wondering whether the reviews are in a different order than expected (and documented)...
Is it possible to run a test against real online data for debugging?

@zhiyelee
Copy link
Collaborator

zhiyelee commented May 26, 2021

Thank you @nafur. Will take a look into this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants