Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requests to python3 package #4678

Closed
th0ma7 opened this issue Jun 13, 2021 · 4 comments · Fixed by #4680
Closed

Add requests to python3 package #4678

th0ma7 opened this issue Jun 13, 2021 · 4 comments · Fixed by #4680

Comments

@th0ma7
Copy link
Contributor

th0ma7 commented Jun 13, 2021

Setup

Package Name: python3/python38

NAS Model: 918+
NAS Architecture: apollolake (x86_64)
DSM version: 6.2.3

Expected behavior

Using an EPG grabber in python I'm getting the following error:

ModuleNotFoundError: No module named 'requests'

Actual behavior

It work on my default Ubuntu setup but fails under Synology DSM

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 13, 2021

@hgy59 working on integrating edit4ever/script.module.zap2epg#37 directly to tvheadend package instead of the zap2it previous work I was on (#4608).

Seems I would require an added pip to be included in the default package...

2021-06-13 09:18:05.683 spawn: Executing "/usr/local/bin/tv_grab_zap2epg"
2021-06-13 09:18:06.028 spawn: Traceback (most recent call last):
2021-06-13 09:18:06.028 spawn:   File "", line 18, in 
2021-06-13 09:18:06.028 spawn: ModuleNotFoundError: No module named 'requests'

@hgy59
Copy link
Contributor

hgy59 commented Jun 13, 2021

Are you planning to create an edit4ever (or zwap2epg) package for spkrepo?

IMHO the python packages include only additional python wheels/modules that are required by pure python spks (i.e. arch=noarch).

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 13, 2021

@hgy59 I'm planning to replace cross/zap2it with a cross/zap2epg (or edit4ever) where I'll simply do a make install under the right epg path of tvheadend i.e. bin and var/epggrab/*. Script will then become part of the standard tvheadend package instead of needing a side package for this. PR #4608 will simply be canceled.

Should the requirement be added directly in the python3 package? or can I simply add a sort of pip in spk/tvheadend for that (there probably is an example I can follow if that's the case).

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 14, 2021

Found well documented proper method of adding to my local package the needed python wheel.
https://github.com/SynoCommunity/spksrc/wiki/Using-wheels-to-distribute-Python-packages
Closing issue.

@th0ma7 th0ma7 closed this as completed Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants