Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSE plugin: Speed up import #3869

Open
gzotti opened this issue Aug 30, 2024 · 1 comment
Open

SSE plugin: Speed up import #3869

gzotti opened this issue Aug 30, 2024 · 1 comment
Labels
enhancement Improve existing functionality importance: low Small problem, rarely visible, no crash subsystem: plugins The issue is related to plugins of planetarium...

Comments

@gzotti
Copy link
Member

gzotti commented Aug 30, 2024

Is your feature request related to a problem? Please describe.
Importing a large number of minor planets from MPC files, e.g. one of the 10.000 body lists, or "unusual objects", takes a long time.

Describe the solution you'd like
We have already improved loading time for OBJ files by applying from_chars(). Probably also parsing MPC files can be sped up. However, it may not be the original number parsing, but what follows.
Without fully going into the code, I fear we are parsing numbers, only to recreate string representations of the same numbers. It may be faster to keep the parsed numbers (strings identified as "containing numbers") as cropped strings (QStringView?) and putting them into the ssystem_minor.ini. Only substitute data that are not available from MPC files.

Describe alternatives you've considered
Waiting, having your favourite beverage...

Additional context
It is probably just a rarely used occasion to mass-load thousands of objects, so it's not a crucial thing, but a "nice-to-have". The SSE plugin UI can probably be improved in numerous other places.

@gzotti gzotti added enhancement Improve existing functionality importance: low Small problem, rarely visible, no crash labels Aug 30, 2024
Copy link

Hello @gzotti!

Thank you for suggesting this enhancement.

@alex-w alex-w added the subsystem: plugins The issue is related to plugins of planetarium... label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality importance: low Small problem, rarely visible, no crash subsystem: plugins The issue is related to plugins of planetarium...
Development

No branches or pull requests

2 participants