Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

The parameter num_cores doesn't work. #351

Open
LilyEvansHogwarts opened this issue Nov 17, 2020 · 2 comments
Open

The parameter num_cores doesn't work. #351

LilyEvansHogwarts opened this issue Nov 17, 2020 · 2 comments

Comments

@LilyEvansHogwarts
Copy link

I read methods/bayesian_optimization.py and find the objective is defined as self.objective = SingleObjective(self.f, self.batch_size, self.funct_name). And I believe it should be changed into self.objective = SingleObjective(self.f, self.num_cores, self.funct_name). Otherwise, the num_cores parameter would be useless.

@LilyEvansHogwarts
Copy link
Author

The original code in methods/bayesian_optimization.py
self.num_cores = num_cores
if f is not None:
self.f = self._sign(f)
self.objective = SingleObjective(self.f, self.batch_size,self.objective_name)
else:
self.f = None
self.objective = None
I believe the code should be changed into:
self.num_cores = num_cores
if f is not None:
self.f = self._sign(f)
self.objective = SingleObjective(self.f, self.num_cores,self.objective_name)
else:
self.f = None
self.objective = None

LilyEvansHogwarts pushed a commit to LilyEvansHogwarts/GPyOpt that referenced this issue Nov 17, 2020
@ragak
Copy link

ragak commented Nov 30, 2020

Thank you for posting this! I wasn't able to use multiple cores until I made this switch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants