Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the portion package to handle intervals #266

Open
nelimee opened this issue Jul 24, 2024 · 1 comment
Open

Introduce the portion package to handle intervals #266

nelimee opened this issue Jul 24, 2024 · 1 comment
Assignees
@pranshiusc
Labels
backend Issue pertaining to the Python backend (tqec package) enhancement New feature or request, may not be in the task flow good first issue Good for newcomers

Comments

@nelimee
Copy link
Contributor

nelimee commented Jul 24, 2024 •
edited
Loading

#256 introduced the Interval and Intervals classes to represent portions of R, all the real numbers. It turns out that a Python package seem to implement exactly that.

LGTM. Just wanted to mention that, I found a package portion that appear to do something similar to Interval.

Originally posted by @inmzhang in #256 (review)

The question is then: "is it worth using that package?".

At first glance I am on the "yes" side, but here are a few points (on both sides) that might help making the best decision:

  • the portion package seems well maintained,
  • using an external package allow us to support less code in tqec,
  • using an external package would increase the time needed to fix a bug and the friction to implement new features,

Any thoughts?
@nelimee nelimee changed the title Introduce the [portion](https://github.com/AlexandreDecan/portion?tab=readme-ov-file#interval-operations) package to handle intervals Introduce the portion package to handle intervals Jul 24, 2024
@nelimee nelimee added enhancement New feature or request, may not be in the task flow backend Issue pertaining to the Python backend (tqec package) good first issue Good for newcomers labels Jul 25, 2024
@pranshiusc
Copy link

Hi, I would like to work on this issue. I have forked the repository, will be working on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pranshiusc pranshiusc

Labels
backend Issue pertaining to the Python backend (tqec package) enhancement New feature or request, may not be in the task flow good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelimee @pranshiusc