Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstring for AwsSecretsManagerSecretsProvider is incorrect #2089

Open
dendraR2 opened this issue Oct 9, 2024 · 1 comment
Open

Docstring for AwsSecretsManagerSecretsProvider is incorrect #2089

dendraR2 opened this issue Oct 9, 2024 · 1 comment

Comments

@dendraR2
Copy link

dendraR2 commented Oct 9, 2024

The docstring for class AwsSecretsManagerSecretsProvider(SecretsProvider) says

 If the secret contains a string payload ("SecretString"):
        - if the `parse_secret_string_as_json` option is True (default):
            {SecretString} will be parsed as a JSON. If successfully parsed, AND the JSON contains a
            top-level object, each entry K/V in the object will also be converted to an entry in the result. V will
            always be casted to a string (if not already a string).
        - If `parse_secret_string_as_json` option is False:
            {SecretString} will be returned as a single entry in the result, with the key being the secret_id.

aws_secrets_manager_secrets_provider.py

Looking down the code the actual option for this should just be json rather than parse_secret_string_as_json

Copy link
Collaborator

thanks for the issue! would you like to contribute a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants