Feature/map loc #66
Feature/map loc #66
Conversation
| # Takes in tuple(start location, map height), altitude, and focal_length] | ||
| # Assumes altitude and focal_length doesn't change | ||
| # Returns flight path of drone to snap images of map |
There was a problem hiding this comment.
These few comments aren't needed, as all this information should be in the docstring.
flight/protoMap.py
Outdated
| print("Camera Width:", cam_w) | ||
| print("Camera Height:", cam_h) |
There was a problem hiding this comment.
Print statements can be commented out or removed, this information will more likely than not be added into a config file or logging statements in the near future.
flight/protoMap.py
Outdated
| print("Map Width:", map_w) | ||
| print("Map Height:", map_h) |
There was a problem hiding this comment.
Same as previous comment; remove/comment print statements
flight/protoMap.py
Outdated
| # Flight path algorithm | ||
| pass |
There was a problem hiding this comment.
Import the testing algorithm here or call the function that contains that algorithm
|
|
||
| Returns | ||
| ------- | ||
| (cam_w, cam_h): Tuple[float, float] |
There was a problem hiding this comment.
A short note on what this tuple contains and is used for would be appreciated.
| center: Tuple[float, float], | ||
| map_w: float, | ||
| map_h: float, | ||
| ) -> List[Tuple[float, float]]: |
There was a problem hiding this comment.
This function also needs a formal docstring.
flight/protoMap.py
Outdated
|
|
||
|
|
||
| # https://stackoverflow.com/questions/7222382/get-lat-long-given-current-point-distance-and-bearing | ||
| def conversion(coord: Tuple[float, float], bearing: float, distance: float) -> Tuple[float, float]: |
There was a problem hiding this comment.
This function also needs a formal docstring.
|
|
||
| return (new_lat, new_lon) | ||
|
|
||
| def flight_path(points: List[Tuple[float, float]], col: int) -> List[Tuple[float, float]]: |
There was a problem hiding this comment.
This function needs a formal docstring as well.
| new_arr = [] | ||
| temp = [] |
There was a problem hiding this comment.
These two arrays need type annotations.
| if i % 2 != 0: | ||
| new_arr[i].reverse() | ||
|
|
||
| path = [] |
There was a problem hiding this comment.
path also needs a type annotation
Kwonadon
force-pushed
the
feature/map_loc
branch
from
9b8341c
to
55d9d83
Compare
Completed creating waypoint locations in lat,long coordinates for mapping.