Clear in Keymapping should say 'Clear chosen controller'

[dfilskov]

In Key-button remapping please rename 'Hold Menu -> Clear' to 'Hold Menu -> Clear chosen controller'.

Or make holding the Menu button clear re-mappings for all controllers / all PIDs.

At least it should say 'No controller chosen' when you open the Key/button remap screen and instantly hold Menu before tapping a controller and it has no PID to clear. Otherwise it seems to work when it actually doesn't.

Also it could say 'Clearing controller' instead or just 'Clearing'.

I couldn't make fire work on any joysticks on the C64 core no matter what I did.

I had to delete the C64_input_*.map files (in config/input) to make Fire work again.

I remapped the buttons (even tapped ESC to 'clear button mapping') and cleared any key<->button mappings by holding the Menu shortcut button. Reset play assignment. Nothing worked. No way to clear the wrong mappings it seems.

[dfilskov]

Here are the files I had in config/inputs.

keymaps_couldn't_be_cleared.zip

[rsn8887]

I found out how it works:
In the button/key remap dialog, you first have to press some button on the controller that you want to clear, THEN hold menu button, or press ESC twice, to clear! Then it works. The reason is that MiSTer needs to know the PID/VID of the controller you want to clear before it can clear it.

[dfilskov]

The reason is that MiSTer needs to know the PID/VID of the controller you want to clear before it can clear it.

Ah I see. Good work! - Thank you!

So 'Clear' does not mean 'Clear all remappings' but rather 'Clear chosen controller'.

I'll update the bug report title.