Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test_shim work when in non-home, or symlinked directories. #140

Open
petersilva opened this issue Jan 2, 2024 · 3 comments
Open

make test_shim work when in non-home, or symlinked directories. #140

petersilva opened this issue Jan 2, 2024 · 3 comments
Assignees

Comments

@petersilva
Copy link
Contributor

petersilva commented Jan 2, 2024

  • on supercomputer, home is a symlinked path.
  • shim_tests use realpath, and assume home is a real path, so some tests fail.

purpose is to get the tests to pass when run on supercomputer.

branches with bits of work on this:

which was merged from:

the non_utf8 and test_shim failures in the normal cases have since been isolated and merged, and so the work here is to extract the symlink related patches and get them into something coherent to merge, so in future, people can run the test_shim on the supercomputer.

@petersilva
Copy link
Contributor Author

uh... not putting a priority on this or anything... I'm just thinking that since you're testing this stuff, this should be on your radar next time you're in the area...

@petersilva
Copy link
Contributor Author

I remember this being painful... it might not be a feasible/worthwhile thing to do.

@reidsunderland
Copy link
Member

I committed the changes to the tests that I had made to get the tests working better on ppp. They're on the https://github.com/MetPX/sarrac/tree/test_tweaks branch.

  • I'm pretty sure I have not tested them on Ubuntu/non-network home
  • I think we also thought that (some of?) the changes might have been working around a bug
    • something to do with symlinks and paths/accepts, but I didn't look into it deep enough to figure it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants