Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] undefined raise_after_is_relative on probe.h #27398

Closed
1 task done
jalcala993 opened this issue Sep 3, 2024 · 5 comments
Closed
1 task done

[BUG] undefined raise_after_is_relative on probe.h #27398

jalcala993 opened this issue Sep 3, 2024 · 5 comments

Comments

@jalcala993
Copy link

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

I just happened to be trying my first ever marlin build for my ender 3 and was hit with a build error introduced on the newest commit.
Configurations.zip

Marlin\src\gcode\calibrate../../module/probe.h:196:127: error: 'raise_after_is_relative' was not declared in this scope; did you mean 'raise_after_is_rel'?

indeed the variable was not properly refactored:

5f0b9d4#diff-844640fa2c3026003779111f0d4594b9370678140e782a408409d57a9c1dc809

Bug Timeline

5f0b9d4

Expected behavior

Build to complete.

Actual behavior

Build fails due to variable name mismatch.

Steps to Reproduce

1.- Download the latest code.
2.- Attempt to build.
2.1 Extract the code
2.2 Open in visual studio
2.3 Install PlatformIO IDE
2.4 Attempt to build

Version of Marlin Firmware

bugfix-2.1.X

Printer model

No response

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

@jalcala993
Copy link
Author

@thinkyhead FYI, some unfortunate timing.

@jalcala993
Copy link
Author

There's another issue at
7aaba66#diff-0b1906f909a22c34a133c2ea6e89d6ed2a54b4694efe1acbafa7e10ad0cb3e55

Marlin\src\gcode\motion\G2_G3.cpp:319:7: error: 'thermalManager' was not declared in this scope

caused by removing
#include "../../module/temperature.h"

@thisiskeithb
Copy link
Member

There's another issue at 7aaba66#diff-0b1906f909a22c34a133c2ea6e89d6ed2a54b4694efe1acbafa7e10ad0cb3e55

Marlin\src\gcode\motion\G2_G3.cpp:319:7: error: 'thermalManager' was not declared in this scope

caused by removing #include "../../module/temperature.h"

Fixed in 8c15a09

@thisiskeithb
Copy link
Member

CI is failing, so we're aware of the issue: https://github.com/MarlinFirmware/Marlin/actions/runs/10674977436/job/29586281708

Thinkyhead is working through these changes.

@thisiskeithb
Copy link
Member

Fixed in 7cd56a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants